Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(migrator): rename switch button text #137

Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat(migrator): rename switch button text #137

merged 1 commit into from
Jul 27, 2023

Conversation

abbylow
Copy link
Contributor

@abbylow abbylow commented Jul 25, 2023

No description provided.

@abbylow abbylow requested a review from jasheal as a code owner July 25, 2023 08:08
@linear
Copy link

linear bot commented Jul 25, 2023

SCR-239 Rename switch network button

Please rename the button to "Switch to Ethereum Mainnet" when on the wrong network.

Please change copy on the main button as well. So from ""Switch to Mainnet"" to "Switch to Ethereum Mainnet"

image.png

@vercel
Copy link

vercel bot commented Jul 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ethcc ✅ Ready (Inspect) Visit Preview Jul 25, 2023 8:12am
mantle-bridge ✅ Ready (Inspect) Visit Preview Jul 25, 2023 8:12am
mantle-converter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 8:12am
mantle-faucet ✅ Ready (Inspect) Visit Preview Jul 25, 2023 8:12am
mantle-token-graph ✅ Ready (Inspect) Visit Preview Jul 25, 2023 8:12am

@abbylow abbylow requested a review from grezle July 25, 2023 09:12
grezle
grezle approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@grezle grezle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Be mindful of the /rpc endpoint when changing chainNames in the future though, we have been using it to construct infura urls, and we broke the bridge making this change (all is good here though, just be sure to check how the chainName is being used)

@abbylow abbylow merged commit 0fd3702 into main Jul 27, 2023
2 checks passed
@abbylow abbylow deleted the scr-239-rename-switch-network-button branch July 27, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grezle grezle grezle approved these changes

@jasheal jasheal Awaiting requested review from jasheal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbylow @grezle